On 04/18/2016 02:26 PM, Dhole wrote:
A few months ago I submited a patch to allow the embedded timestamps by C/C++ macros to be set externally [2], which was already an improvement over [1]. I was told to wait until the GCC 7 stage 1 started to send this patch again.
+/* Read SOURCE_DATE_EPOCH from environment to have a deterministic + timestamp to replace embedded current dates to get reproducible + results. Returns -1 if SOURCE_DATE_EPOCH is not defined. */ +long long +get_source_date_epoch()
Always have a space before open-paren. Maybe this should return time_t. See below.
+/* Read SOURCE_DATE_EPOCH from environment to have a deterministic + timestamp to replace embedded current dates to get reproducible + results. Returns -1 if SOURCE_DATE_EPOCH is not defined. */ +extern long long get_source_date_epoch();
Double space after the end of a sentence. Space before open paren.
+ source_date_epoch = get_source_date_epoch(); + cpp_init_source_date_epoch(parse_in, source_date_epoch);
Spaces.
+/* Initialize the source_date_epoch value. */ +extern void cpp_init_source_date_epoch (cpp_reader *, long long);
Also thinking we should be using time_t here.
/* Sanity-checks are dependent on command-line options, so it is called as a subroutine of cpp_read_main_file (). */
We don't write () to mark function names.
+ tb = gmtime ((time_t*) &pfile->source_date_epoch);
Space before the "*". But this cast looks ugly and unreliable (think big-endian). This is why I would prefer to move to a time_t representation sooner.
2016-04-18 Eduard Sanou<dh...@openmailbox.org> Matthias Klose<d...@debian.org> * c-common.c (get_source_date_epoch): New function, gets the environment variable SOURCE_DATE_EPOCH and parses it as long long with error handling. * c-common.h (get_source_date_epoch): Prototype. * c-lex.c (c_lex_with_flags): set parse_in->source_date_epoch.
Add blank lines after the end of the names in ChangeLogs. Bernd