> Hi Martin, > > On Thu, 2016-06-09 13:24:10 +0200, Martin Liška <mli...@suse.cz> wrote: > > On 06/08/2016 02:41 PM, Jan Hubicka wrote: > > > Adding hash for this prupose is bit of an overkill (there are > > > definitly cheaper ways of solving so), but it will hardly affect compile > > > time, so the pathc is OK. > > > > Sending the final version where I added comments and I also changed > > dump scanning to cover the new dump format. > > I just noticed a build problem my Build Robot found > (http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=569576): > > g++ -fno-PIE -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE > -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall > -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute > -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros > -Wno-overlength-strings -fno-common -DHAVE_CONFIG_H -I. -I. > -I/scratch/4/jbglaw/regular/repos/gcc/gcc > -I/scratch/4/jbglaw/regular/repos/gcc/gcc/. > -I/scratch/4/jbglaw/regular/repos/gcc/gcc/../include > -I/scratch/4/jbglaw/regular/repos/gcc/gcc/../libcpp/include > -I/scratch/4/jbglaw/regular/repos/gcc/gcc/../libdecnumber > -I/scratch/4/jbglaw/regular/repos/gcc/gcc/../libdecnumber/dpd > -I../libdecnumber -I/scratch/4/jbglaw/regular/repos/gcc/gcc/../libbacktrace > -o predict.o -MT predict.o -MMD -MP -MF ./.deps/predict.TPo > /scratch/4/jbglaw/regular/repos/gcc/gcc/predict.c > /scratch/4/jbglaw/regular/repos/gcc/gcc/predict.c:62:3: error: redeclaration > of ‘NONE’ > NONE,
Hmm, namespace conflict. I guess renaming enum items to REASON_* should solve it easily. Or we can add a namespace. Martin, both variants of fix are pre-approved. Honza
