On Sat, 18 Jun 2016, Bernhard Reutner-Fischer wrote: > A branch with a name matching scan-assembler pattern triggers > inappropriate FAIL. > > E.g. branch fixups-testsuite and > - gcc.target/i386/pr65871-?.c (scan-assembler-not "test") > - gcc.target/i386/pr41442.c (scan-assembler-times "test|cmp" 2) > etc. > > This is a recurring problem as can be seen by some -fno-ident additions > by commits from e.g. Michael Meissner over the years: builtins-58.c, > powerpc/pr46728-?.c > > The patch below adds -fno-ident if a testcase contains one of > scan-assembler, scan-assembler-not or scan-assembler-times.
This reminds me of a related but not opposing idea that I have never acted on (besides bouncing it off a global maintainer quite some time ago, with a positive response), to make common identifier-like and filename-like strings invalid for use in scan-assembler; there'd have to be a meta-character such as whitespace. It would help for "test" but admittedly not for "test|cmp" given e.g. an objdir named "/tmp/mytest/gccmp/nop1". Then there'd be an error thrown for such test-cases, alerting the author (well, hopefully) that the test-case is in error, and a comment in the scan-assembler code would make it prominent that there'd have to be a whitespace or meta-like character (i.e. [^-a-zA-Z_\.]) included in the string. Yes, I know whitespace can be included in filenames and that's regularly done at least on some systems, but I bet you really get into problems trying that for srcdir or objdir in a gcc build. Sorry, still not going to act on it for now, but feel free if so inclined. brgds, H-P
