On 7 August 2016 at 04:04, Ville Voutilainen <ville.voutilai...@gmail.com> wrote: >> Good news! This compiles now! I learned the technique from Anthony >> Williams's implementation, whose code also compiles, but it requires a >> close-to-trunk gcc, which implements >> "...for unions, at least one non-static data member is of non-volatile >> literal type, ...". >> >> Also added it as a test. >> >> Please verify the implementation by looking at _Uninitialized and >> _Variant_storage. > > > Sounds very promising, I'll try to play with it before the end of the > weekend. Jonathan will be on holiday > next week so we have time before this gets committed. We might want to > entertain the idea of running > the tests at https://github.com/efcs/libcxx/tree/variant although that > implementation isn't something we should > adopt things from.
I did the playing, looks very good to me. Thanks for doing the work, Tim! (Jonathan, ship it :) )
