On Fri, 2016-08-19 at 16:51 +0000, Joseph Myers wrote: > On Fri, 19 Aug 2016, David Malcolm wrote: > > > Please could you take this opportunity to add some examples to the > > header comment for that function, both for the common cases e.g. > > "f", > > and for the new suffixes; nothing in the patch body appears to > > document > > them. (ideally, referencing the standard). > > > > Also, it would be good to add some more comments to the function > > body. > > For example, in this hunk: > > > > - if (f + d + l + w + q > 1 || i > 1) > > + if (f + d + l + w + q + fn + fnx > 1 || i > 1) > > > > should it read something like : > > /* Reject duplicate suffixes, contradictory suffixes [...] */ > > > > where "[...]" is something relating to fn + fnx, which I can't > > figure > > out in the absence of the standard you're referring to. > > How does this seem? I think > <http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1945.pdf> was the > last > public draft of TS 18661-3 before publication.
Thanks - the comments make things much clearer. [...snip...]
