On Fri, Sep 2, 2011 at 2:52 PM, Uros Bizjak <ubiz...@gmail.com> wrote: > On Thu, Sep 1, 2011 at 12:27 PM, Ilya Enkovich <enkovich....@gmail.com> wrote: >>> >>> this seems to not allow cycles_best to drop with lower width, but >>> that it can't should be an implementation detail of get_required_cycles. >>> To make it not so, can you add a comment before the loop, like >>> >>> /* get_required_cycles is monotonically increasing with lower width >>> so we can perform a binary search for the minimal width that still >>> results in the optimal cycle count. */ >>> >> >> Fixed. Thanks! >> >>> >>> With the above change the non-x86 specifc parts are ok. Please get >>> approval for them from a x86 maintainer. >>> >> >> Could please someone review x86 part? > > I assume that you need to split tune attribute to int and FP part to > handle reassociation for other targets, since Atom handles both in the > same way. > > Please also describe function return value in the comment (and perhaps > in documentation, too). > > OK with this addition.
Btw, I would expect integer add and integer multiply to have different settings for some targets which would mean splitting this up even further ... Richard. > Thanks, > Uros. >
