Hi David,

On Mon, Oct 17, 2016 at 09:54:35AM -0400, David Edelsohn wrote:
> This patch shifts earlier the point during compilation where the
> rs6000 backend adds decoration to symbols: to encode_section_info.

> -  /* Currently C++ toc references to vtables can be emitted before it
> -     is decided whether the vtable is public or private.  If this is
> -     the case, then the linker will eventually complain that there is
> -     a reference to an unknown section.  Thus, for vtables only,
> -     we emit the TOC reference to reference the symbol and not the
> -     section.  */

I think this comment should go...

>    if (VTABLE_NAME_P (name))
>      {
>        RS6000_OUTPUT_BASENAME (file, name);

... before here.

Otherwise looks fine.  Do you want this tested on Linux before you
commit?  We never test on AIX beforehand either ;-)


Reply via email to