On Tue, Nov 8, 2016 at 3:32 AM, kugan <kugan.vivekanandara...@linaro.org> wrote: > Hi, > > In tree-ssa-coalesce, register_ssa_partition ) and > register_ssa_partition_check have lost their meaning over various commits > and now just verifies that ssa_var is indeed a SSA_NAME and not a > virtual_operand_p. It is confusing when one look at if for the fist time and > would expect more while reading the register_ssa_partition. > > Attached patch just changes it to verify_ssa_for_coalesce to better reflect > what it is doing now. > > Bootstrap and regression testing is ongoing. Is this OK for trunk if no > regressions?
Hum, can you retain the inline wrapper please? I find the new name verify_ssa_for_coalesce bad as tree-ssa-live.h is something generic, not just coalescing related. I'd say a better improvement would be to remove register_ssa_partition completely. Richard. > Thanks, > Kugan > > > > gcc/ChangeLog: > > 2016-11-08 Kugan Vivekanandarajah <kug...@linaro.org> > > * tree-ssa-coalesce.c (register_default_def): Remove usage of arg > map which is not used at all. > (create_outofssa_var_map): Use renamed verify_ssa_for_coalesce from > register_ssa_partition. > * tree-ssa-live.c (verify_ssa_for_coalesce): Renamed > register_ssa_partition. > (register_ssa_partition_check): Remove. > * tree-ssa-live.h (register_ssa_partition): Renamed to > verify_ssa_for_coalesce
