And I have confirmed the problem is still here. I'll be reinserting the option.
On 9/12/11, Gabriel Charette <gcharet...@gmail.com> wrote: > Oops forgot to reply all... > > On Mon, Sep 12, 2011 at 7:40 AM, Diego Novillo <dnovi...@google.com> wrote: >> This patch removes all the XPASS noise from pph.exp runs by pruning >> the output from the base compiles (thanks Ian for the pointer). It >> add some comments as well. >> >> Lawrence, I noticed that we do not seem to need -I. -fno-dwarf2-cfi-asm >> anymore. So, I removed them. I'm not sure I remember exactly why you >> had added them, but since removing them produces no changes to the >> results, I just took them out. > > This was a hack because Lawrence was getting different asm checksums > for the pph asm xdiff because his configuration would output some > additional dwarf2-cfi assembly. Thus, no single expected diff checksum > would work for both of us. > > Cheers, > Gab > -- Lawrence Crowl
