On 11/30/2016 09:24 PM, David Malcolm wrote:

        * read-md.c (have_error): New global, copied from errors.c.
        (fatal): New function, copied from errors.c.

I would have expected the function to go into diagnostic.c, but actually there are already various functions of this sort in read-md. I'd request you place it near fatal_at, and maybe add this to errors.h:

inline bool seen_error ()
  return have_error;

and replace explicit uses of have_error with that to unify things a bit.


Reply via email to