On Thu, Dec 01, 2016 at 12:24:37PM +0100, Paolo Bonzini wrote: > > > On 30/11/2016 13:46, Segher Boessenkool wrote: > > if (JUMP_P (use_insn)) > > continue; > > > > + /* Also don't substitute into a conditional trap insn -- it can > > become > > + an unconditional trap, and that is a flow control insn. */ > > + if (GET_CODE (PATTERN (use_insn)) == TRAP_IF) > > + continue; > > Should there be a predicate that catches JUMP_Ps but also TRAP_IF?
Maybe. A conditional TRAP_IF is quite unlike a JUMP, and having two separate statements here is handy because I need to put that comment somewhere ;-) Segher
