Hi,
This patch fixes ICE reported by PR78691, it adds requirement of integral type
for the outer
expression of pattern ((convert1 (minmax ((convert2 (x) c)))) -> minmax (x c)).
Test case checked on ppc, bootstrap and test on x86_64 ongoing, is it OK if no
new failure?
Thanks,
bin
2016-12-06 Bin Cheng <bin.ch...@arm.com>
PR tree-optimization/78691
* match.pd ((convert1 (minmax ((convert2 (x) c)))) -> minmax (x c)):
Require integral type for the outer expression.
gcc/testsuite/ChangeLog
2016-12-06 Bin Cheng <bin.ch...@arm.com>
PR tree-optimization/78691
* gcc.target/i386/pr78691-i386.c: New test.
* gcc.target/powerpc/pr78691-ppc.c: New test.
diff --git a/gcc/match.pd b/gcc/match.pd
index dbb9103..16dfb58 100644
--- a/gcc/match.pd
+++ b/gcc/match.pd
@@ -1378,7 +1378,8 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT)
(for minmax (min max)
(simplify
(convert (minmax@0 (convert @1) INTEGER_CST@2))
- (if (types_match (@1, type) && int_fits_type_p (@2, type)
+ (if (INTEGRAL_TYPE_P (type)
+ && types_match (@1, type) && int_fits_type_p (@2, type)
&& TYPE_SIGN (TREE_TYPE (@0)) == TYPE_SIGN (type)
&& TYPE_PRECISION (TREE_TYPE (@0)) > TYPE_PRECISION (type))
(minmax @1 (convert @2)))))
diff --git a/gcc/testsuite/gcc.target/i386/pr78691-i386.c
b/gcc/testsuite/gcc.target/i386/pr78691-i386.c
new file mode 100644
index 0000000..f4b8855
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr78691-i386.c
@@ -0,0 +1,14 @@
+/* PR tree-optimization/78691 */
+/* { dg-options "-Os -m16" } */
+
+int fn1(char *p1, char *p2) {
+ int a;
+ for (;;)
+ switch (*p2) {
+ case 'c':
+ while (--a > 0)
+ *p1++ = ' ';
+ p1++;
+ a--;
+ }
+}
diff --git a/gcc/testsuite/gcc.target/powerpc/pr78691-ppc.c
b/gcc/testsuite/gcc.target/powerpc/pr78691-ppc.c
new file mode 100644
index 0000000..73e3c87
--- /dev/null
+++ b/gcc/testsuite/gcc.target/powerpc/pr78691-ppc.c
@@ -0,0 +1,18 @@
+/* PR tree-optimization/78691 */
+/* { dg-options "-Os -m32" } */
+
+int *b;
+int fn1() {
+ char *c;
+ int a;
+ for (;;)
+ switch (*b) {
+ case 'c':
+ while (--a > 0)
+ *c++ = ' ';
+ c++;
+ if (a)
+ a = sizeof(void *);
+ }
+}
+