On Wed, Nov 30, 2016 at 1:04 AM, Christophe Lyon <christophe.l...@linaro.org> wrote: > Hi Tamar, > > > On 29 November 2016 at 14:54, James Greenhalgh <james.greenha...@arm.com> > wrote: >> On Tue, Nov 29, 2016 at 01:48:22PM +0000, Kyrill Tkachov wrote: >>> >>> On 29/11/16 09:50, Tamar Christina wrote: >>> >Hi All, >>> > >>> >The new patch contains the proper types for the intrinsics that should be >>> >returning uint64x1 >>> >and has the rest of the comments by Christophe in them. >>> >>> Ok with an appropriate ChangeLog entry. >> >> Also OK from an AArch64 persepctive based on the detailed review from >> Christophe. >> >> Thanks, >> James >> > > After you committed this patch (r242962), I've noticed some > regressions as follows: > * on aarch64, vreinterpret_p128 and vreinterpret_p64 fail to compile > with errors like > warning: implicit declaration of function 'vreinterpretq_p64_p128 > warning: implicit declaration of function 'vreinterpretq_p128_s8 > error: incompatible types when assigning to type 'poly64x2_t' from type 'int' > etc... > > * on arm configured for armv8-a, several tests fail to link or compile: > vbsl.c:(.text+0x24f0): undefined reference to `expected_poly64x1' > vdup-vmov.c:227:38: error: 'expected0_poly64x1' undeclared > vdup_lane.c:(.text+0x1584): undefined reference to `expected_poly64x1' > > You can have more details at > http://people.linaro.org/~christophe.lyon/cross-validation/gcc/trunk/242962/report-build-info.html
I see the expected_poly64x1 failures also for aarch64: https://gcc.gnu.org/ml/gcc-testresults/2016-12/msg00738.html FAIL: gcc.target/aarch64/advsimd-intrinsics/vbsl.c -O0 (test for excess errors) Excess errors: vbsl.c:(.text+0x1dec): undefined reference to `expected_poly64x1' vbsl.c:(.text+0x1df0): undefined reference to `expected_poly64x1' vbsl.c:(.text+0x1e20): undefined reference to `expected_poly64x1' vbsl.c:(.text+0x1e24): undefined reference to `expected_poly64x1' vbsl.c:(.text+0x2a74): undefined reference to `expected_poly64x2' vbsl.c:(.text+0x2a78): undefined reference to `expected_poly64x2' vbsl.c:(.text+0x2aa8): undefined reference to `expected_poly64x2' vbsl.c:(.text+0x2aac): undefined reference to `expected_poly64x2' .... FAIL: gcc.target/aarch64/advsimd-intrinsics/vld1_dup.c -O0 (test for excess errors) Excess errors: /home/jenkins/workspace/BuildThunderX_native_gcc_upstream/gcc/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1_dup.c:175:38: error: 'expected0_poly64x1' undeclared (first use in this function); did you mean 'expected_poly64x1'? /home/jenkins/workspace/BuildThunderX_native_gcc_upstream/gcc/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1_dup.c:175:38: error: 'expected0_poly64x2' undeclared (first use in this function); did you mean 'expected0_poly64x1'? /home/jenkins/workspace/BuildThunderX_native_gcc_upstream/gcc/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1_dup.c:178:38: error: 'expected1_poly64x1' undeclared (first use in this function); did you mean 'expected0_poly64x1'? /home/jenkins/workspace/BuildThunderX_native_gcc_upstream/gcc/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1_dup.c:178:38: error: 'expected1_poly64x2' undeclared (first use in this function); did you mean 'expected1_poly64x1'? /home/jenkins/workspace/BuildThunderX_native_gcc_upstream/gcc/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1_dup.c:181:38: error: 'expected2_poly64x1' undeclared (first use in this function); did you mean 'expected1_poly64x1'? /home/jenkins/workspace/BuildThunderX_native_gcc_upstream/gcc/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1_dup.c:181:38: error: 'expected2_poly64x2' undeclared (first use in this function); did you mean 'expected2_poly64x1'? etc. > > > Christophe
