On 01/03/2017 11:11 AM, Jakub Jelinek wrote:
On Tue, Jan 03, 2017 at 11:08:05AM -0700, Jeff Law wrote:
What if REGNO is 2147483648 (assume 32 bit host). That will get us into the
else block in df_ref_record as it's >= FIRST_PSEUDO_REGISTER.
In df_ref_create_structure, we use the same expression to compute REGNO, but
this time it's interpreted as a signed integer, so -2147483648. That gets us
into the path where we call TEST_HARD_REG_BIT and thus the oob array index.
Right?
The patch is OK. It does highlight the desire to pick the right type and
consistently use it.
Note I think we require --disable-werror for the not so common bootstrap
configurations, only normal bootstrap and profiledbootstrap are supposed to
be --enable-werror free. At least that is my understanding of the general
preference, there are too many bootstrap options and too many different sets
of false positives. Not talking about this particular patch, just a general
comment.
Agreed. I was on the fence WRT these patches for that exact reason.
Jeff
