On Mon, 19 Sep 2011 20:02:16 +0200 Pierre Vittet <pier...@pvittet.com> wrote:
> Hello > > Here is a patch allowing to compute correctly the md5 of a file sequence > even with the bug rapported here: > http://gcc.gnu.org/ml/gcc-patches/2011-09/msg00963.html. > > The function will work with both gcc 4.6 without the patch and a gcc > with the patch applied. Thanks. I committed the patch (rev 178983 of MELT branch), with a slightly changed ChangeLog.MELT entry: 2011-09-19 Pierre Vittet <pier...@pvittet.com> * melt-runtime.c (meltgc_string_hex_md5sum_file_sequence): Catenated files stream call md5_process_block, we only call md5_process_bytes for the last data of the last file. Pierre found a painful bug in GCC trunk's libiberty/md5.c, which is impacting GCC MELT. The issue is that when fed with several files, a wrong checksum was computed, because of pointer alignment mess. Pierre's current patch is workaround for MELT; but both Pierre & me hope that the patch http://gcc.gnu.org/ml/gcc-patches/2011-09/msg00963.html will eventually be reviewed and accepted. The workaround is still needed inside MELT, because we both want it to work as a plugin with current gcc 4.6. Regards. -- Basile STARYNKEVITCH http://starynkevitch.net/Basile/ email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359 8, rue de la Faiencerie, 92340 Bourg La Reine, France *** opinions {are only mine, sont seulement les miennes} ***
