On 15/01/17 19:07 +0200, Ville Voutilainen wrote:
   PR libstdc++/78389
   Fix backwards size adjustments.

I don't think repeating this text here and ...

   * include/bits/list.tcc (merge(list&&)):
   Fix backwards size adjustments.

... here is useful.

More useful would be a good Git-style commit log with a separate
description on the first line. So the svn commit would have a subject
line, followed by a blank line, followed by the content of the
ChangeLog entry e.g.

PR78389 fix backwards size adjustments

        PR libstdc++/78389
        * include/bits/list.tcc (merge(list&&)): Fix backwards size
        adjustments.
        (merge(list&&, _StrictWeakOrdering)): Likewise.
        * testsuite/23_containers/list/operations/78389.cc: Add
        better test for the sizes.

See the output of "git log --pretty=oneline --abbrev-commit" for why
that's useful (and how messy and unhelpful that output is when commits
don't have a separate summary on the first line). See also
http://chris.beams.io/posts/git-commit/

Anyway ...

OK for trunk with the additional changes to use better magic numbers
in the tests.

Reply via email to