Moore, Catherine <catherine_mo...@mentor.com> writes: > > -----Original Message----- > > From: Matthew Fortune [mailto:matthew.fort...@imgtec.com] > > Sent: Thursday, January 19, 2017 5:30 PM > > To: Moore, Catherine <catherine_mo...@mentor.com> > > Cc: 'Aurelien Jarno' <aurel...@aurel32.net>; 'Richard Sandiford' > > <rdsandif...@googlemail.com>; Loosemore, Sandra > > <sandra_loosem...@mentor.com>; Yunqiang Su > > <yunqiang...@imgtec.com>; 'gcc-patches' <gcc-patches@gcc.gnu.org> > > Subject: RE: [patch mips/gcc] add build-time and runtime options to > > disable or set madd.fmt type > > > > Matthew Fortune <matthew.fort...@imgtec.com> writes: > > > I've rewritten/simplified this patch as it provides far too much > > control > > > to end users who will undoubtedly shoot themselves in the foot so to > > > speak. The option I intend to support is simply --with-madd4 -- > > without-madd4 > > > and -mmadd4 -mno-madd4. This is a simple enable/disable on top of > > > architecture checks to use/not use the madd4 family of instructions. > > > > > > We have to keep each of these unusual features simple so that we > > can somehow > > > reason about them in the future. > > > > > > > Here is the tested patch. Configure time default set/not set tested and > > testsuite > > fixes in place to deal with the fallout from running with the madd4 > > instructions > > disabled. Tests done with an o32 config on mips64el-linux-gnu. If > > there is any > > other fallout from other test configurations I'll catch those as I try to > > get the > > rest of the testsuite issues resolved before release. > > > > Catherine, any issues to raise on this new option? > > I committed this patch after fixing a couple of typos in the documentation > and ChangeLog > entry. > No other objections. > Catherine
Thanks Catherine. I'll check to see what if/any documentation changes have gone in without your review and send you a list in case you have time to review it before release. Thanks, Matthew
