On Wed, Jan 25, 2017 at 4:25 PM, Segher Boessenkool <seg...@kernel.crashing.org> wrote: > On Wed, Jan 25, 2017 at 04:08:54PM +0000, Bin.Cheng wrote: >> > I was worried this patch would prevent too many other optimisations, >> > so I looked into better options. I didn't find any. I tested the >> > effects of the patch on 31 architectures (building GCC and then Linux >> Thanks very much for this, that's a lot of testing work. > > The power of scripting ;-) Of course it doesn't help if you do not > have enough free disk space, and other yak shaving, sigh. > > Analysing the differences is mostly manual of course. Luckily there > weren't any. I also tested a few other changes at the same time; if > I would have known this one was easy in the end... Oh well. > >> I will >> revise the patch by explaining why is the change, as well as the >> impact. > > Yes please. Make sure to mention the PR, it helps finding the mail > threads and commits a lot.
Hi all, Thanks very much for helping. I committed below change to trunk. ------------------------------------------------------------------------ r244979 | amker | 2017-01-27 14:42:23 +0000 (Fri, 27 Jan 2017) | 8 lines PR rtl-optimization/78559 * combine.c (try_combine): Discard REG_EQUAL and REG_EQUIV for other_insn in combine. gcc/testsuite PR rtl-optimization/78559 * gcc.c-torture/execute/pr78559.c: New test. Thanks, bin > > > Segher