On 02/03/2017 09:39 AM, Jakub Jelinek wrote:
On Fri, Feb 03, 2017 at 09:13:23AM -0700, Martin Sebor wrote:
I'm not opposed to the changes, certainly not to cleaning things up,
but I don't think now is the time to be making these tweaks. Jakub's
patch is fine with me without those tweaks, and with the correction
What do you mean by my patch without those tweaks?
...
I fear this isn't the last fix needed, the code is very complex and not
sufficiently covered by testcases, so if we don't want to make the code
more maintainable now, I'd be strongly for just turning
-fprintf-return-value off by default for the release. Bogus warnings
can be lived with or worked around, silent wrong-code is much worse.
I mean without changes to the content of the notes. If you feel
it important to simplify the code now that's okay with me.
I'm not empowered to either approve or reject any changes so what
say is obviously just my input into Jeff's decision. I also care
a lot about this work so I'm not going to resist when faced with
a threat of having it disabled. If leaving the optimization
enabled is conditional on it then feel free to make whatever
changes you see fit.
Martin
