Jakub Jelinek <ja...@redhat.com> writes: > optimize all ones vectors in simplify-rtx.c (and i386 expansion): > http://gcc.gnu.org/ml/gcc-patches/2011-09/msg01364.html
I wonder whether we should have a CONSTM1_RTX(MODE). It seems inconsistent to have vector 0s and 1s, but only have integer -1s. As far as simplify-rtx.c goes, I think all_ones_cst should cover the existing CONST_INT_P case too. CONST_INTs have to be represented as sign-extended, and "trueop1" should still have mode "mode", so something's wrong if the current code matches things that aren't constm1_rtx. The simplify-rtx.c change looks good otherwise. Richard
