On Mon, Mar 20, 2017 at 01:05:15PM -0500, Aaron Sawdey wrote: > > 2017-03-20 Aaron Sawdey <acsaw...@linux.vnet.ibm.com> > > > > PR target/80083 > > * config/rs6000/rs6000.md (*movsi_internal1): incorrect > > constraints > > for alternatives 14/15.
A changelog line should describe what is changed, not what was wrong; it should start with a capital; and you changed alternatives 13 and 14 (they start counting at 0). > --- gcc/config/rs6000/rs6000.md (revision 246224) > +++ gcc/config/rs6000/rs6000.md (working copy) > @@ -6727,7 +6727,7 @@ > [(set (match_operand:SI 0 "rs6000_nonimmediate_operand" > "=r, r, r, ?*wI, ?*wH, > m, ?Z, ?Z, r, r, > - r, ?*wIwH, ?*wJwK, ?*wK, ?*wJwK, > + r, ?*wIwH, ?*wJwK, ?*wJwK, ?*wu, > ?*wJwK, ?*wH, ?*wK, ?*wIwH, ?r, > r, *c*l, *h, *h") The change to alt 13 is obvious enough. Could you explain alt 14 a bit more though? It used to allow more than it does after this patch; are those handled by other alternatives? Segher
