> I've got the visium, rx and mn103 patches handy to ensure they don't > regress. aarch64 doesn't seem to be affected either way but I didn't > investigate why -- I expected it to improve with your change.
Thanks for taking care of this, but a couple of comments in config/visium are now backwards and must be adjusted too: Index: config/visium/visium.c =================================================================== --- config/visium/visium.c (revision 248139) +++ config/visium/visium.c (working copy) @@ -922,8 +922,8 @@ empty_delay_slot (rtx_insn *insn) return 1; } -/* Wrapper around single_set which returns the first SET of a pair if the - second SET is to the flags register. */ +/* Wrapper around single_set which returns the second SET of a pair if the + first SET is to the flags register. */ static rtx single_set_and_flags (rtx_insn *insn) Index: config/visium/visium.md =================================================================== --- config/visium/visium.md (revision 248139) +++ config/visium/visium.md (working copy) @@ -240,7 +240,7 @@ (define_code_attr add_str [(plus "plus") ;; ;; Substitutions. ;; -;; They are used to define the second instruction of the pairs required by +;; They are used to define the first instruction of the pairs required by ;; the postreload compare elimination pass, with a first variant for the ;; logical insns and a second variant for the arithmetic insns. ;; I'm going to install the fixlet. -- Eric Botcazou