On Fri, Jun 23, 2017 at 12:29 PM, Bin.Cheng <amker.ch...@gmail.com> wrote: > On Mon, Jun 19, 2017 at 4:18 PM, Richard Biener > <richard.guent...@gmail.com> wrote: >> On Mon, Jun 19, 2017 at 3:37 PM, Bin.Cheng <amker.ch...@gmail.com> wrote: >>> On Wed, Jun 14, 2017 at 2:47 PM, Richard Biener >>> <richard.guent...@gmail.com> wrote: >>>> On Mon, Jun 12, 2017 at 7:03 PM, Bin Cheng <bin.ch...@arm.com> wrote: >>>>> Hi, >>>>> This patch refactors struct partition for later distribution. It records >>>>> bitmap of data references in struct partition rather than vertices' data >>>>> in >>>>> partition dependence graph. It simplifies code as well as enables >>>>> following >>>>> rewriting. >>>>> Bootstrap and test on x86_64 and AArch64. Is it OK? >>>> >>>> Ok. >>> Hi, >>> I updated patch by merging read/write data references together in >>> struct partition. This helps remove code duplication. Is it OK? >> >> Ok. > Sorry I made a mistake when separating patch. The previous patch uses > un-initialized variable "dir". Though related code was removed by > following patch, for this specific version, the code is wrong. Is it > OK? > Like: > + int dir = pg_add_dependence_edges (rdg, dir, > + partition1->datarefs, > + partition2->datarefs); > Now changed to > + int dir = pg_add_dependence_edges (rdg, 0, > + partition1->datarefs, > + partition2->datarefs);
Ok. > Thanks, > bin > >> >> Richard. >> >>> Thanks, >>> bin >>> 2017-06-07 Bin Cheng <bin.ch...@arm.com> >>> >>> * tree-loop-distribution.c (struct partition): New field recording >>> its data reference. >>> (partition_alloc, partition_free): Init and release data refs. >>> (partition_merge_into): Merge data refs. >>> (build_rdg_partition_for_vertex): Collect data refs for partition. >>> (pg_add_dependence_edges): Change parameters from vector to bitmap. >>> Update uses. >>> (distribute_loop): Remve data refs from vertice data of partition >>> graph.
