On Tue, Jul 11, 2017 at 10:42 AM, Martin Liška <[email protected]> wrote:
> And there are remaining references of Pascal:
>
> 1) dbxout.c:
>
> 1661 {
> 1662 stabstr_C ('r');
> 1663 if (TREE_TYPE (type))
> 1664 dbxout_type (TREE_TYPE (type), 0);
> 1665 else if (TREE_CODE (type) != INTEGER_TYPE)
> 1666 dbxout_type (type, 0); /* E.g. Pascal's ARRAY [BOOLEAN] of
> INTEGER */
> 1667 else
> 1668 {
>
> Can we remove that Jason? It's dead according to LCOV output.
I don't know dbxout, but it seems pretty harmless; I'd be inclined to
keep it even if no current front ends use it.
> 2) dwarf2out.c:
>
> 23295
> 23296 #if 0
> 23297 /* Don't generate either pointer_type DIEs or reference_type DIEs
> here.
> 23298 Use modified_type_die instead.
> 23299 We keep this code here just in case these types of DIEs may be
> needed to
> 23300 represent certain things in other languages (e.g. Pascal)
> someday. */
> 23301
> 23302 static void
> 23303 gen_pointer_type_die (tree type, dw_die_ref context_die)
> 23304 {
> 23305 dw_die_ref ptr_die
> --
> 23312 }
> 23313
> 23314 /* Don't generate either pointer_type DIEs or reference_type DIEs
> here.
> 23315 Use modified_type_die instead.
> 23316 We keep this code here just in case these types of DIEs may be
> needed to
> 23317 represent certain things in other languages (e.g. Pascal)
> someday. */
> 23318
> 23319 static void
> 23320 gen_reference_type_die (tree type, dw_die_ref context_die)
> 23321 {
> 23322 dw_die_ref ref_die, scope_die = scope_die_for (type, context_die);
>
> The piece of code is guarded in #if 0, is it candidate for removal?
Yes, go ahead.
> 3) stor-layout.c:
>
> 2648 /* Set the extreme values of TYPE based on its precision in bits,
> 2649 then lay it out. Used when make_signed_type won't do
> 2650 because the tree code is not INTEGER_TYPE.
> 2651 E.g. for Pascal, when the -fsigned-char option is given. */
> 2652
> 2653 void
> 2654 fixup_signed_type (tree type)
> 2655 {
> 2656 int precision = TYPE_PRECISION (type);
> 2657
> 2658 set_min_and_max_values_for_integral_type (type, precision,
> SIGNED);
> 2659
> 2660 /* Lay out the type: set its alignment, size, etc. */
> 2661 layout_type (type);
>
> This is probably useful not just for Pascal?
Agreed.
Jason
