> 
> This looks fine, though the commit message tells me it's not a good
> idea, but it would be nice to know _why_ it's not good.  Might be nice
> to know for future reference.
> 
Again LRA, expand time subregs are not handled by LRA, as far as I can tell. 
Moreover, this option is by default off, and even using the old IRA may not be 
a good idea to have subregs before register allocation step.

> Also, there's no test.  Was there an issue that revealed this as not a
> good idea?  Could that become a test?
> 

This error was found while running dg for our port with LRA on and this option 
on. Once removed the mexpand-adddi, a test is impossible to get.

Thanks,
Claudiu

Reply via email to