On 07/13/2017 04:54 PM, Jeff Law wrote: > On 07/12/2017 07:44 PM, Segher Boessenkool wrote: >>> /* The default is not to move the stack pointer. */ >>> +/* The default is not to move the stack pointer, unless we are using >>> + stack clash prevention stack checking. */ >>> #ifndef STACK_CHECK_MOVING_SP >>> -#define STACK_CHECK_MOVING_SP 0 >>> +#define STACK_CHECK_MOVING_SP\ >>> + (flag_stack_check == STACK_CLASH_BUILTIN_STACK_CHECK) >>> #endif >> >> Missing space before that backslash. > Similarly. > >> >> The documentation for STACK_CHECK_CONFIG_SP needs updating (its default >> is no longer zero, for one). > Yea. Missed that. I actually need to go back and look at this again. > I'm not entirely sure it's necessary -- it may be a relic from when I > thought more -fstack-check infrastructure was going to be reusable. Just a follow-up to myself. As I suspected, we can just drop the STACK_CHECK_MOVING_SP changes. Between changes in overall direction and moving stack-clash protection out of -fstack-check= STACK_CHECK_MOVING_SP changes simply aren't needed anymore.
jeff
