On 07/11/2017 04:35 AM, Martin Liška wrote:
> Hello.
> 
> This fixes majority of autoFDO test-cases.
> 
> Patch can boostrap and survives regression tests.
> 
> Ready for trunk?
> Thanks,
> Martin
> 
> gcc/ChangeLog:
> 
> 2017-07-11  Martin Liska  <mli...@suse.cz>
> 
>     * auto-profile.c (afdo_annotate_cfg): Assign zero counts to
>     BBs and edges seen by autoFDO.
I went back and forth on this a couple times.  I could argue that if we
don't have data for the edge from auto-fdo, then the proper value is
uninitialized().  But I think the response to that argument is that if
the edge didn't show up in the afdo run, then it's counters should be
zero'd as they weren't triggered during the afdo run.

I think a comment immediately prior to the initialization seems wise. OK
with that change.

jeff

Reply via email to