On Wed, Aug 02, 2017 at 10:40:32AM -0600, Jeff Law wrote: > On 07/31/2017 05:25 PM, Segher Boessenkool wrote: > > This changes combine to always use insn_cost, not pattern_cost. I don't > > intend to commit it like this: it calls recog more often than necessary, > > and it is very ugly (no, don't look at it). But it's good enough to test > > things with. > So what do you expect this is going to look like when you're done? The > other target independent patches all look reasonable so I think it's > really a matter of how you want to want to use the new infrastructure in > combine.c (which will become the template for how other passes might use > the infrastructure as well).
Just like this: use insn_cost everywhere instead of pattern_cost. The change still needed is that in the current prototype here I have to swap in and out the new patterns more often than necessary, and call recog twice for every new pattern (the first time to see if combine came up with insns that exist at all, the second time to see how expensive they are). This of course is a bit wasteful (recog isn't cheap), and unnecessary. Patch 2 already uses insn_cost (instead of pattern_cost / insn_rtx_cost) in cfgrtl.c, dse.c, and in ifcvt.c in one place (the other three places weren't trivial to convert). Segher
