On 02/08/17 21:30, Jeff Law wrote:
On 07/24/2017 12:03 AM, Sebastian Huber wrote:
gcc/
PR libgcc/61152
* aarch64/rtems.h: Add GCC Runtime Library Exception. Format
changes.
* arm/rtems.h: Likewise.
* bfin/rtems.h: Likewise.
* i386/rtemself.h: Likewise.
* lm32/rtems.h: Likewise.
* m32c/rtems.h: Likewise.
* m68k/rtemself.h: Likewise.
* microblaze/rtems.h: Likewise.
* mips/rtems.h: Likewise.
* moxie/rtems.h: Likewise.
* nios2/rtems.h: Likewise.
* powerpcspe/rtems.h: Likewise.
* rs6000/rtems.h: Likewise.
* rtems.h: Likewise.
* sh/rtems.h: Likewise.
* sh/rtemself.h: Likewise.
* sparc/rtemself.h: Likewise.
This seems horribly wrong. Did anyone ack this change? I'm fully
supportive of target maintainers taking care of their areas, but
licensing stuff probably should get explicitly ack'd.
I just reviewed all the rtems config files and I don't see anything in
any of them that deserves a runtime exception with the possible
exception of rs6000/rtems.h.
Seriously. Redefining the CPP builtins? LINK_SPEC? #undefs? Those
are not things we should be granting an exception for.
The one that looks marginal to me would be rs6000/rtems.h and its
definition of CRT_CALL_STATIC_FUNCTION.
I asked on the mailing list:
https://gcc.gnu.org/ml/gcc/2017-07/msg00171.html
Jakub Jelinek said that for header files included by libgcc it is
important whether they have the runtime exception or not:
https://gcc.gnu.org/ml/gcc/2017-07/msg00176.html
There is also this PR61152 from 2014
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61152
which adds the runtime exception to a couple of gcc/ subdirectory files
(including some RTEMS files). So, I had no explicit acknowledge, but my
impression was that I did simply fix some left over files.
If you don't add the runtime exception to files included by libgcc, then
the user of GCC must check that these files contain no content that
deserves a copyright. Is this really user friendly?
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.hu...@embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
