On 07/13/2017 03:05 AM, Richard Sandiford wrote: > This patch adds another machine_mode wrapper for modes that are > known to be COMPLEX_MODE_P. There aren't yet many places that make > use of it, but that might change in future. > > 2017-07-13 Richard Sandiford <richard.sandif...@linaro.org> > Alan Hayward <alan.hayw...@arm.com> > David Sherwood <david.sherw...@arm.com> > > gcc/ > * coretypes.h (complex_mode): New type. > * gdbhooks.py (build_pretty_printer): Handle it. > * machmode.h (complex_mode): New class. > (complex_mode::includes_p): New function. > (is_complex_int_mode): Likewise. > (is_complex_float_mode): Likewise. > * genmodes.c (get_mode_class): Handle complex mode classes. > * function.c (expand_function_end): Use is_complex_int_mode. > > gcc/go/ > * go-lang.c (go_langhook_type_for_mode): Use is_complex_float_mode. OK.
I think that's the whole set. I want to go back and review the API issue raised early in the kit, but otherwise I don't see any concerns. Obviously the trunk has continued to evolve since the kit was posted. It's safe to assume there'll be minor updates as a result -- I trust your judgment on addressing any such fallout without going through another review cycle. Jeff