Hello,

currently, the testsuite return value is ignored by make. It is a little 
annoying if one wants to check automatically for regressions as we have to 
parse the testsuite output.
This patch reverts to the normal make behaviour, which is to not ignore 
commands' return values. Note: As a result the -k flag has to be added to the 
make command line if one wants the tests to continue after one failure.

OK for trunk?

Mikael

PS: Jakub, I CCed you as you are the author of the Makefile chunk.
2011-10-09  Mikael Morin  <mikael.mo...@sfr.fr>

        * Makefile.in (check-parallel-%): Don't ignore testsuite errors.
Index: Makefile.in
===================================================================
--- Makefile.in	(révision 179710)
+++ Makefile.in	(copie de travail)
@@ -5116,10 +5124,10 @@ $(patsubst %,%-subtargets,$(lang_checks_paralleliz
 # Otherwise check-$lang isn't parallelized and runtest is invoked just with
 # the $(RUNTESTFLAGS) arguments.
 check-parallel-% : site.exp
-	-test -d plugin || mkdir plugin
-	-test -d $(TESTSUITEDIR) || mkdir $(TESTSUITEDIR)
+	test -d plugin || mkdir plugin
+	test -d $(TESTSUITEDIR) || mkdir $(TESTSUITEDIR)
 	test -d $(TESTSUITEDIR)/$(check_p_subdir) || mkdir $(TESTSUITEDIR)/$(check_p_subdir)
-	-(rootme=`${PWD_COMMAND}`; export rootme; \
+	(rootme=`${PWD_COMMAND}`; export rootme; \
 	srcdir=`cd ${srcdir}; ${PWD_COMMAND}` ; export srcdir ; \
 	cd $(TESTSUITEDIR)/$(check_p_subdir); \
 	rm -f tmp-site.exp; \

Reply via email to