On Wed, Sep 13, 2017 at 10:19:50PM +0200, Jakub Jelinek wrote:
> On Wed, Sep 13, 2017 at 05:18:00AM -0700, H.J. Lu wrote:
> > > In LINK_EH_SPEC you use %{!static|static-pie:--eh-frame-hdr}, what
> > > exactly do you mean by that? The way that works is if -static
> > > isn't present on the command line OR if -static -static-pie OR
> > > -static-pie -static is present, you get --eh-frame-hdr. Didn't you
> > > mean %{!static:%{!static-pie:--eh-frame-hdr}}, i.e. don't emit
> > > --eh-frame-hdr for either -static or -static-pie?
> >
> > It means "pass --eh-frame-hdr to ld if -static isn't used or -static-pie
> > is used since -static-pie needs PT_GNU_EH_FRAME segment.
>
> Ok.
>
> So here is an updated patch (also fixed whitespace in i386/gnu-user.h
> because the indentation there didn't match the nesting).
>
> Bootstrapped/regtested on {x86_64,i686,powerpc64,powerpc64le}-linux,
> ok for trunk?
> At least the rs6000 part is really important, as bootstrap
> is broken on powerpc*.
The rs6000 part looks fine, thanks!
Segher
