On 25 September 2017 at 20:19, Mike Stump <mikest...@comcast.net> wrote:
> On Sep 23, 2017, at 10:52 AM, Christophe Lyon <christophe.l...@linaro.org>
> wrote:
>> The attached patch would apply after reverting yours.
>> I've applied it against r253072 (just before your patch) and the
>> results are visible at:
>> http://people.linaro.org/~christophe.lyon/cross-validation/gcc-test-patches/253072-hw-misalign2/report-build-info.html
>>
>> Do they match your expectations? It looks like a few testcases need to
>> be adjusted,
>> or new bugs are uncovered.
>>
>> If the patch OK with a suitable ChangeLog entry?
>
> So, I wasn't sure what you meant by the comment. Below is an example of !
> working.
>
> % proc b {} { return 0 }
> % set v [expr ![b]]
> 1
> % set v [ expr !![b]]
> 0
> % proc b {} { return 1 }
> % set v [expr ![b]]
> 0
> % set v [ expr !![b]]
> 1
>
> Given that, if you want to use a simple set var value, you should just do
> that directly. [b] is the placeholder for an [] expression, if you want to
> invert that. v is the placeholder for the thing you want to set. All the
> other bits should be used as given. Given that code, I'd be interested in
> what you want to put in the comment, if any.
>
> set et_vect_hw_misalign_saved($et_index) [expr
> ![check_effective_target_arm_vect_no_misalign]]
>
> seems like what you want, does that work?
>
Yes, thanks! I was missing the 'expr' part.
Here is what I have committed (r253187), to avoid further noise in the results.
2017-09-26 Christophe Lyon <christophe.l...@linaro.org>
* lib/target-supports.exp (check_effective_target_vect_hw_misalign):
Fix arm check.
* lib/target-supports.exp
Index: gcc/testsuite/lib/target-supports.exp
===================================================================
--- gcc/testsuite/lib/target-supports.exp (revision 253186)
+++ gcc/testsuite/lib/target-supports.exp (working copy)
@@ -5951,7 +5951,7 @@
set et_vect_hw_misalign_saved($et_index) 1
}
if { [istarget arm*-*-*] } {
- set et_vect_hw_misalign_saved($et_index)
![check_effective_target_arm_vect_no_misalign]
+ set et_vect_hw_misalign_saved($et_index) [expr
![check_effective_target_arm_vect_no_misalign]]
}
}
verbose "check_effective_target_vect_hw_misalign:\
Thanks,
Christophe
