On Sat, Oct 14, 2017 at 5:44 PM, David Edelsohn <dje....@gmail.com> wrote: > This patch has broken bootstrap on AIX and possibly powerpc64-linux. > Was this patch tested on any architecture other than x86?
No. > /nasfarm/edelsohn/src/src/libgcc/emutls.c: In function '__emutls_get_address': > /nasfarm/edelsohn/src/src/libgcc/emutls.c:139:11: internal compiler > error: in invalid_void, at config/rs6000/rs6000.md:10804 > pointer offset = __atomic_load_n (&obj->loc.offset, __ATOMIC_ACQUIRE); > ^~~~~~ Basically, the patch does only: +expand_memory_blockage (void) +{ + if (targetm.have_memory_blockage) + emit_insn (targetm.gen_memory_blockage ()); + else + expand_asm_memory_blockage (); +} So, if the target doesn't declare memory_blockage pattern, as is the case with rs6000, I really fail to see what could go wrong here. Uros.