On Tue, Oct 11, 2011 at 9:47 AM, Jason Merrill <ja...@redhat.com> wrote: > That looks pretty good, but do you really need to build up a separate data > structure to search? You seem to be searching it in the same order that > it's built up, so why not just walk the expansion chain directly when > searching?
Agreed. Also, please keep linemap_location_before_p, if needed as macro that expands to the comparison function. That aids readability.
