Hi, On 1 November 2017 at 03:12, Jim Wilson <wil...@tuliptree.org> wrote: > On Tue, 2017-10-31 at 14:35 +1100, Kugan Vivekanandarajah wrote: >> Ping ? >> >> I see that Jim has clarified the comments from Andrew. > > Andrew also suggested that we add a testcase to the testsuite. I > didn't do that. I did put a testcase to reproduce in the bug report. > See > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82533 > It should be a relatively simple matter of taking that testcase, > compiling to assembly with -mcpu=falkor, then doing a pattern search > for a str q [r+r] instruction, and fail if it is present. > > Jim >
Here is the testcase. Is the original patch OK with the testcase attached. Thanks, Kugan
diff --git a/gcc/testsuite/gcc.target/aarch64/pr82533.c b/gcc/testsuite/gcc.target/aarch64/pr82533.c new file mode 100644 index 0000000..fa28ffa --- /dev/null +++ b/gcc/testsuite/gcc.target/aarch64/pr82533.c @@ -0,0 +1,11 @@ +/* { dg-do compile } */ +/* { dg-options "-mcpu=falkor -O2 -ftree-vectorize" } */ + +void +copy (int N, double *c, double *a) +{ + for (int i = 0; i < N; ++i) + c[i] = a[i]; +} + +/* { dg-final { scan-assembler-not "str\tq\[0-9\]+, \\\[x\[0-9\]+, x\[0-9\]+\\\]" } } */
gcc/testsuite/ChangeLog: 2017-11-02 Kugan Vivekanandarajah <kugan.vivekanandara...@linaro.org> * gcc.target/aarch64/pr82533.c: New test.