Hi Sandra,

> The testcase gcc.target/mips/msa.c gives dozens of FAILs if it's tested
> with a GCC configured to default to -fno-common, because of patterns
> like
> 
> /* { dg-final { scan-assembler-times "\t.comm\tv16i8_\\d+,16,16" 3 } }
> */
> 
> Seems like the simplest solution is to force -fcommon for this test.
> OK?

Looks like a good choice to me. The test has too much expected output to
cope with -fno-common as well and it does not degrade the value of the test.

Please go ahead.

Thanks,
Matthew

Reply via email to