Re: [PATCH, rs6000] Repair vec_xl, vec_xst, vec_xl_be, vec_xst_be built-in functions

[Segher Boessenkool]

Hi!

On Tue, Nov 14, 2017 at 02:24:13PM -0600, Bill Schmidt wrote:
> +      for (i = 0; i < 16; ++i)
> +             perm[i] = GEN_INT (reorder[i]);
> +
> +      pcv = force_reg (V16QImode,
> +                       gen_rtx_CONST_VECTOR (V16QImode,
> +                                          gen_rtvec_v (16, perm)));
> +      emit_insn (gen_altivec_vperm_v8hi_direct (operands[0], subreg2,
> +                                                     subreg2, pcv));
> +      DONE;

Many whitespace problems on these lines, please fix.  More times later.

> +       (match_operand:V16QI 1 "vsx_register_operand" "wa")
> +       (parallel [(const_int 15) (const_int 14)
> +                  (const_int 13) (const_int 12)
> +                  (const_int 11) (const_int 10)
> +                  (const_int  9) (const_int  8)
> +                  (const_int  7) (const_int  6)
> +                  (const_int  5) (const_int  4)
> +                  (const_int  3) (const_int  2)
> +                  (const_int  1) (const_int  0)])))]

Here, too.

The rest looks fine.  Thanks!


Segher