vectorizable_mask_load_store replaces scalar IFN_MASK_LOAD calls with
dummy assignments, so that they never survive vectorisation. This patch
moves the code to vect_transform_loop instead, so that we only change
the scalar statements once all of them have been vectorised.
This makes it easier to handle other types of functions that need
stubbing out, and also makes it easier to handle groups and patterns.
Richard
2017-11-17 Richard Sandiford <richard.sandif...@linaro.org>
gcc/
* tree-vect-loop.c (vect_transform_loop): Stub out scalar
IFN_MASK_LOAD calls here rather than...
* tree-vect-stmts.c (vectorizable_mask_load_store): ...here.
Index: gcc/tree-vect-loop.c
===================================================================
--- gcc/tree-vect-loop.c 2017-11-17 09:06:36.818836579 +0000
+++ gcc/tree-vect-loop.c 2017-11-17 09:06:42.552270752 +0000
@@ -7743,6 +7743,25 @@ vect_transform_loop (loop_vec_info loop_
gsi_next (&si);
}
} /* stmts in BB */
+
+ /* Stub out scalar statements that must not survive vectorization.
+ Doing this here helps with grouped statements, or statements that
+ are involved in patterns. */
+ for (gimple_stmt_iterator gsi = gsi_start_bb (bb);
+ !gsi_end_p (gsi); gsi_next (&gsi))
+ {
+ gcall *call = dyn_cast <gcall *> (gsi_stmt (gsi));
+ if (call && gimple_call_internal_p (call, IFN_MASK_LOAD))
+ {
+ tree lhs = gimple_get_lhs (call);
+ if (!VECTOR_TYPE_P (TREE_TYPE (lhs)))
+ {
+ tree zero = build_zero_cst (TREE_TYPE (lhs));
+ gimple *new_stmt = gimple_build_assign (lhs, zero);
+ gsi_replace (&gsi, new_stmt, true);
+ }
+ }
+ }
} /* BBs in loop */
/* The vectorization factor is always > 1, so if we use an IV increment of 1.
Index: gcc/tree-vect-stmts.c
===================================================================
--- gcc/tree-vect-stmts.c 2017-11-17 09:06:36.818836579 +0000
+++ gcc/tree-vect-stmts.c 2017-11-17 09:06:42.553230162 +0000
@@ -2342,20 +2342,6 @@ vectorizable_mask_load_store (gimple *st
STMT_VINFO_RELATED_STMT (prev_stmt_info) = new_stmt;
prev_stmt_info = vinfo_for_stmt (new_stmt);
}
-
- /* Ensure that even with -fno-tree-dce the scalar MASK_LOAD is removed
- from the IL. */
- if (STMT_VINFO_RELATED_STMT (stmt_info))
- {
- stmt = STMT_VINFO_RELATED_STMT (stmt_info);
- stmt_info = vinfo_for_stmt (stmt);
- }
- tree lhs = gimple_call_lhs (stmt);
- new_stmt = gimple_build_assign (lhs, build_zero_cst (TREE_TYPE (lhs)));
- set_vinfo_for_stmt (new_stmt, stmt_info);
- set_vinfo_for_stmt (stmt, NULL);
- STMT_VINFO_STMT (stmt_info) = new_stmt;
- gsi_replace (gsi, new_stmt, true);
return true;
}
else if (vls_type != VLS_LOAD)
@@ -2472,23 +2458,6 @@ vectorizable_mask_load_store (gimple *st
}
}
- if (vls_type == VLS_LOAD)
- {
- /* Ensure that even with -fno-tree-dce the scalar MASK_LOAD is removed
- from the IL. */
- if (STMT_VINFO_RELATED_STMT (stmt_info))
- {
- stmt = STMT_VINFO_RELATED_STMT (stmt_info);
- stmt_info = vinfo_for_stmt (stmt);
- }
- tree lhs = gimple_call_lhs (stmt);
- new_stmt = gimple_build_assign (lhs, build_zero_cst (TREE_TYPE (lhs)));
- set_vinfo_for_stmt (new_stmt, stmt_info);
- set_vinfo_for_stmt (stmt, NULL);
- STMT_VINFO_STMT (stmt_info) = new_stmt;
- gsi_replace (gsi, new_stmt, true);
- }
-
return true;
}
