On Tue, Oct 31, 2017 at 02:47:29PM +0100, Dominik Inführ wrote:
> Hi,
>
> I have a custom optimization pass, that moves an expression into an
> POST_INC-expression. GCC then ICE’s in df-scan.c since it expects REG_P to be
> true for POST_INC’s operand. aarch64_simd_mem_operand_p doesn’t seem to check
> POST_INC’s operand. Here is a patch that fixes this for me, although I am not
> sure if this is the right way to address this. GCC bootstraps and it causes
> no test regressions.
OK!
Reviewed-by: James Greenhalgh <james.greenha...@arm.com>
Thanks,
James
>
> Dominik
>
> ChangeLog:
> 2017-10-31 Dominik Infuehr <dominik.infu...@theobroma-systems.com>
>
> * config/aarch64/aarch64.c (aarch64_simd_mem_operand_p): Check
> if register given as operand for POST_INC.
>
> -----
>
> diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c
> index ed30b8c..bb61506 100644
> --- a/gcc/config/aarch64/aarch64.c
> +++ b/gcc/config/aarch64/aarch64.c
> @@ -11850,8 +11850,15 @@ aarch64_simd_lane_bounds (rtx operand, HOST_WIDE_INT
> low, HOST_WIDE_INT high,
> bool
> aarch64_simd_mem_operand_p (rtx op)
> {
> - return MEM_P (op) && (GET_CODE (XEXP (op, 0)) == POST_INC
> - || REG_P (XEXP (op, 0)));
> + if (!MEM_P (op))
> + return false;
> +
> + rtx opnd = XEXP (op, 0);
> +
> + if (GET_CODE (opnd) == POST_INC)
> + opnd = XEXP(opnd, 0);
> +
> + return REG_P (opnd);
> }
>
> /* Emit a register copy from operand to operand, taking care not to
