Hi!
On Fri, Nov 17, 2017 at 11:30:27AM -0600, Will Schmidt wrote:
> [testsuite]
> * fold-vec-neg-int.c: Specify -mcpu=power8
Dot at end of sentence (quite a few times), please.
> -/* { dg-final { scan-assembler-times "vspltisw|vxor" 1 } } */
> +//# Power9 added xxspltib instruction.
> +/* { dg-final { scan-assembler-times "vspltisw|vxor|xxspltib" 1 } } */
That's not the usual comment style (and it won't work with all compiler
settings). But does this comment bring any value? Just leave it out?
> --- a/gcc/testsuite/gcc.target/powerpc/fold-vec-abs-int-fwrapv.c
> +++ b/gcc/testsuite/gcc.target/powerpc/fold-vec-abs-int-fwrapv.c
> @@ -1,11 +1,11 @@
> /* Verify that overloaded built-ins for vec_abs with int
> inputs produce the right results. */
>
> /* { dg-do compile } */
> /* { dg-require-effective-target powerpc_altivec_ok } */
> -/* { dg-options "-maltivec -O2 -fwrapv" } */
> +/* { dg-options "-maltivec -O2 -fwrapv -mcpu=power8" } */
Is this testcase really testing something specific to power8 codegen?
Making all these testcases use -mcpu=power8 means they won't be tested
with any other settings. (Also, does that work if the user puts another
-mcpu= in RUNTESTFLAGS).
I'm all for making the testresults cleaner, but let's not do that by
(effectively) disabling all failing tests ;-)
(Please split this up a bit when you repost it btw).
Segher
