On Wed, Nov 22, 2017 at 8:10 PM, Thomas Koenig <tkoe...@netcologne.de> wrote: > Hi Janne, > >>> So, attached is a new version of the patch. No update >>> on the ChangeLog. OK for trunk? >> >> Yup, just really fix the copyright and string length stuff first. Thanks! > > > Committed as rev 255070 with the fixes. > > There are still some files which mention Fortran 95, that can be fixed > later.
That's ok, I wasn't expecting you to fix all such occurences, just the new files you added. However, to continue my nitpicking (sorry!), it seems that in many cases compare_fcn still takes an integer length argument. Could you make that gfc_charlen_type as well? Or maybe size_t, since the argument is passed straight to memcmp{_char4} anyway? Please consider such a patch pre-approved. Thanks! -- Janne Blomqvist