On Mon, Dec 18, 2017 at 10:09 AM, Marek Polacek <pola...@redhat.com> wrote: > Here the problem was that cxx_eval_call_expression can cache the result of a > constexpr call in constexpr_call_table, but we have to be careful, after > store_init_value the result might be invalid. So I believe we also have to > clear the constexpr call table. I've lumped it together with clearing > cv_cache.
Hmm, that seems like a big hammer; the problem isn't that store_init_value makes the result invalid, it's that the result calculated during store_init_value (when we can treat the object as constant) isn't relevant later (when the object is no longer constant). So we want to avoid caching when we're called for the initial value. Maybe by changing if (depth_ok && !non_constant_args) to if (depth_ok && !non_constant_args && ctx->strict) ? Does that work?
