On Wed, Jan 3, 2018 at 2:10 PM, Thomas Koenig <tkoe...@netcologne.de> wrote: > Hi Janne, > >> attached is a patch that makes the two attached testcases work. It >> applies on top of the charlen->size_t patch. In the formatted I/O >> stuff, I have mostly used ptrdiff_t to avoid having to deal with >> signed/unsigned issues, as the previous code was using int. > > > Did you regression-test?
Ah yes, I forgot to mention that. Yes, I did, though only on x86_64-linux-gnu > If yes, I'd say this patch is OK (all the changes look obvious > enough). > > With this, your character length patch is also OK. We can then > open individual PRs for the other issues. > > However, I'd ask you to wait for a day or so with committing > so that other people also have a chance for a (final) look > at this. Thanks! Dominique mentioned on IRC about some incoming comments, so I guess it makes sense to wait a few days. -- Janne Blomqvist
