Thanks David, I've saved you comments in our Wiki so I hope I'll remember and do better next time.
Regards, Cordialement, Tony Reix ATOS / Bull SAS ATOS Expert IBM Coop Architect & Technical Leader Office : +33 (0) 4 76 29 72 67 1 rue de Provence - 38432 Échirolles - France www.atos.net ________________________________________ De : David Edelsohn [dje....@gmail.com] Envoyé : vendredi 19 janvier 2018 17:36 À : REIX, Tony Cc : gcc-patches@gcc.gnu.org; Ian Lance Taylor; BERGAMINI, DAMIEN Objet : Re: [PATCH,AIX] Optimize parsing of include files. On Thu, Jan 18, 2018 at 9:56 AM, REIX, Tony <tony.r...@atos.net> wrote: > > Description: > * This patch optimizes the time required for parsing the include files. > > Tests: > * AIX: Build: SUCCESS > - build made by means of gmake on AIX. > > ChangeLog: > * xcoff.c: Optimize parsing of include files. Hi, Tony The ChangeLog should be more detailed. * xcoff.c (xcoff_incl_compare): New function. (xcoff_incl_search): New function. (xcoff_process_linenos): Use bsearch to find include file. (xcoff_initialize_fileline): Sort include file information. The rest is okay, although the calls to bsearch and backtrace_qsort don't follow the style of other files. This is okay. Thanks, David