Hi Bernhard:

Thanks your comment, I'll update that :)

Hi Jim:

> I don't see a copyright assigment for Ruslan.  This patch is big enough that 
> it requires one.

I'll ask him for that.

> The config.gcc patch is including dbxelf.h.  Stabs support is obsolete and 
> unmaintained.  Do you really need this?  If you include this, it will 
> probably just be dropped soon after the gcc-8 release anyways, so it is 
> probably better to not include it in the first place.

I'll try to remove that, thanks :)

> The libgcc/config.host patch is including files that weren't included in the 
> patch.

Oh, okay, I guess it's something port from older freebsd riscv-gcc, I
should update that, thanks.

On Tue, Jan 30, 2018 at 4:28 AM, Jim Wilson <j...@sifive.com> wrote:
> On 01/28/2018 07:26 PM, Kito Cheng wrote:
>>
>> gcc/ChangeLog
>>
>> 2018-01-29  Ruslan Bukin  <b...@bsdpad.com>
>>                      Kito Cheng  <kito.ch...@gmail.com>
>>
>>          * config.gcc (riscv*-*-freebsd*): New.
>>          * config/riscv/freebsd.h: New.
>>
>> libgcc/ChangeLog
>>
>> 2018-01-29  Ruslan Bukin  <b...@bsdpad.com>
>>
>>          * libgcc/config.host: Support RISC-V FreeBSD.
>
>
> I don't see a copyright assigment for Ruslan.  This patch is big enough that
> it requires one.
>
> The config.gcc patch is including dbxelf.h.  Stabs support is obsolete and
> unmaintained.  Do you really need this?  If you include this, it will
> probably just be dropped soon after the gcc-8 release anyways, so it is
> probably better to not include it in the first place.
>
> The libgcc/config.host patch is including files that weren't included in the
> patch.
>
> Jim
>
> --
> You received this message because you are subscribed to the Google Groups
> "RISC-V Patches" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to patches+unsubscr...@groups.riscv.org.
> To post to this group, send email to patc...@groups.riscv.org.
> Visit this group at
> https://groups.google.com/a/groups.riscv.org/group/patches/.
> To view this discussion on the web visit
> https://groups.google.com/a/groups.riscv.org/d/msgid/patches/b9b59f94-7699-b3f3-0eb8-b06c033c0423%40sifive.com.
>
> For more options, visit
> https://groups.google.com/a/groups.riscv.org/d/optout.

Reply via email to