On Tue, Feb 6, 2018 at 3:28 PM, Jakub Jelinek <ja...@redhat.com> wrote: > On Fri, Feb 02, 2018 at 03:13:21PM -0500, Jason Merrill wrote: >> > Or should I change the switch body to do other kind = overrides? >> >> I think we want to avoid clobbering NON_LVALUE_EXPR location wrappers, too. >> >> This has gotten large enough that it should break out into its own function. >> >> OK with those changes. > > So like this? Bootstrapped/regtested on x86_64-linux and i686-linux. > > + case NON_LVALUE_EXPR: > + if (location_wrapper_p (*postfix_expression))
I don't think we need this test, as NON_LVALUE_EXPR should only appear as a location wrapper. OK with it removed. Jason