On Tue, Feb 13, 2018 at 04:11:36PM -0600, Kelvin Nilsen wrote: > PR 78303 was recently marked RESOLVED, WONTFIX. The resolution was to > deprecate the troublesome command-line option. > > This patch begins the process of deprecation by issuing a warning > message when this command-line option is specified. The patch has > bootstrapped and tested without regressions on > powerpc64le-unknown-linux. Is this ok for trunk?
Is -w appropriate for all these testcases, i.e. would we want to see any other warnings that are generated for them? Or will we remember to remove -w when we remove -maltivec=be :-) Will you write a wwwdocs patch as well, please? Is the plan to remove this in GCC 9 already? > --- gcc/config/rs6000/rs6000.c (revision 257395) > +++ gcc/config/rs6000/rs6000.c (working copy) > @@ -4028,6 +4028,13 @@ rs6000_option_override_internal (bool global_init_ > if (global_init_p) > rs6000_isa_flags_explicit = global_options_set.x_rs6000_isa_flags; > > + /* We plan to deprecate the -maltivec=be option. For now, just > + issue a warning message. */ > + if (global_init_p > + && (rs6000_altivec_element_order == 2)) Please remove the useless parens. Otherwise okay for trunk. Thanks! Segher
