On 03/09/2018 07:29 AM, Thomas Schwinge wrote: > On Thu, 1 Mar 2018 13:17:01 -0800, Cesar Philippidis <ce...@codesourcery.com> > wrote: >> To reduce the size of the final patch, >> I've separated all of the misc. function and variable renaming into this >> patch. > > Yes, please always do such refactoring changes independently of other > functionality changes. > > >> This patch also introduces a new populate_offload_attrs function. > > I'm seeing: > > [...]/gcc/config/nvptx/nvptx.c: In function 'void nvptx_reorg()': > [...]/gcc/config/nvptx/nvptx.c:4451:3: warning: > 'oa.offload_attrs::vector_length' may be used uninitialized in this function > [-Wmaybe-uninitialized] > if (oa->vector_length == 0) > ^ > [...]/gcc/config/nvptx/nvptx.c:4516:21: note: > 'oa.offload_attrs::vector_length' was declared here > offload_attrs oa; > ^ > > That must be "populate_offload_attrs" inlined into "nvptx_reorg". I > can't tell yet why it complains about "vector_length" only but not about > the others.
I got lazy and just merged that function as-is. That warning will go away once the reset of the vector length changes are in. Cesar
