On Fri, Apr 06, 2018 at 08:55:47PM +0100, Christophe Lyon wrote: > Hi, > > 2018-04-06 12:15 GMT+02:00 Sameera Deshpande <sameera.deshpa...@linaro.org>: > > Hi Christophe, > > > > Please find attached the updated patch with testcases. > > > > Ok for trunk? > > Thanks for the update. > > Since the new intrinsics are only available on aarch64, you want to > prevent the tests from running on arm. > Indeed gcc.target/aarch64/advsimd-intrinsics/ is shared between the two > targets. > There are several examples on how to do that in that directory. > > I have also noticed that the tests fail at execution on aarch64_be.
I think this is important to fix. We don't want the big-endian target to have failing implementations of the Neon intrinsics. What is the nature of the failure? >From what I can see, nothing in the patch prevents using these intrinsics on big-endian, so either the intrinsics behaviour is wrong (we have a wrong code bug), or the testcase expected behaviour is wrong. I don't think disabling the test for big-endian is the right fix. We should either fix the intrinsics, or fix the testcase. Thanks, James
